Re: [PATCH 14/33] staging/olpc: lock_fb_info can't fail

[Daniel Vetter]

On Fri, May 24, 2019 at 10:53:35AM +0200, Daniel Vetter wrote:
> Simply because olpc never unregisters the damn thing. It also
> registers the framebuffer directly by poking around in fbdev
> core internals, so it's all around rather broken.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> Cc: Jens Frederich <jfrederich@xxxxxxxxx>
> Cc: Daniel Drake <dsd@xxxxxxxxxx>
> Cc: Jon Nettleton <jon.nettleton@xxxxxxxxx>

Hi Greg,

Somehow get_maintainers didn't pick you up for this. Ack for merging this
through drm/fbdev? It's part of a bigger series to rework fbdev/fbcon
interactions.

Thanks, Daniel

> ---
>  drivers/staging/olpc_dcon/olpc_dcon.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> index 6b714f740ac3..a254238be181 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -250,11 +250,7 @@ static bool dcon_blank_fb(struct dcon_priv *dcon, bool blank)
>  	int err;
>  
>  	console_lock();
> -	if (!lock_fb_info(dcon->fbinfo)) {
> -		console_unlock();
> -		dev_err(&dcon->client->dev, "unable to lock framebuffer\n");
> -		return false;
> -	}
> +	lock_fb_info(dcon->fbinfo);
>  
>  	dcon->ignore_fb_events = true;
>  	err = fb_blank(dcon->fbinfo,
> -- 
> 2.20.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch