Re: [PATCH 32/33] staging/olpc_dcon: Add drm conversion to TODO

[Greg KH]

On Mon, May 27, 2019 at 09:11:26AM +0200, Daniel Vetter wrote:
> On Fri, May 24, 2019 at 10:53:53AM +0200, Daniel Vetter wrote:
> > this driver is pretty horrible from a design pov, and needs a complete
> > overhaul. Concrete thing that annoys me is that it looks at
> > registered_fb, which is an internal thing to fbmem.c and fbcon.c. And
> > ofc it gets the lifetime rules all wrong (it should at least use
> > get/put_fb_info).
> > 
> > Looking at the history, there's been an attempt at dropping this from
> > staging in 2016, but that had to be reverted. Since then not real
> > effort except the usual stream of trivial patches, and fbdev has been
> > formally closed for any new hw support. Time to try again and drop
> > this?
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> > Cc: Jens Frederich <jfrederich@xxxxxxxxx>
> > Cc: Daniel Drake <dsd@xxxxxxxxxx>
> > Cc: Jon Nettleton <jon.nettleton@xxxxxxxxx>
> 
> Hi Greg
> 
> Again get_mainatiners didn't pick you up on this somehow (I manually added
> you now for the next round). Do you want to pick this up to staging, or
> ack for merging through drm/fbdev as part of the larger fbdev/fbcon
> rework?
> 
> Also, I think time to retry and attempt at dropping this imo ...

Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>