Re: [PATCH] drm/omapdrm: fix warning PTR_ERR_OR_ZERO can be used

From: Tomi Valkeinen
Date: Mon May 27 2019 - 05:11:05 EST


Hi,

On 25/05/2019 17:56, Matteo Croce wrote:
On Sat, May 25, 2019 at 9:30 AM Hariprasad Kelam
<hariprasad.kelam@xxxxxxxxx> wrote:

fix below warnings reported by coccicheck


Hi,

a similar patch was nacked because it makes backports more difficult:

https://lore.kernel.org/lkml/3dec4093-824e-b13d-d712-2dedd445a7b7@xxxxxx/

Tomi, what's your thought?


I don't particularly like the PTR_ERR_OR_ZERO, and changing old code to use it seem pointless.

Tomi

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki