Re: [PATCH] drivers: base: power: Use of_clk_get_parent_count()

[Geert Uytterhoeven]

Hi Kefeng,

On Sat, May 25, 2019 at 1:54 PM Kefeng Wang <wangkefeng.wang@xxxxxxxxxx> wrote:
> Use of_clk_get_parent_count() instead of open coding.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/base/power/clock_ops.c
> +++ b/drivers/base/power/clock_ops.c
> @@ -195,8 +195,7 @@ int of_pm_clk_add_clks(struct device *dev)
>         if (!dev || !dev->of_node)
>                 return -EINVAL;
>
> -       count = of_count_phandle_with_args(dev->of_node, "clocks",
> -                                          "#clock-cells");
> +       count = of_clk_get_parent_count(dev->of_node);
>         if (count <= 0)
>                 return -ENODEV;


Given of_clk_get_parent_count() is provided by <linux/of_clk.h>, I think
you should add an include for that.

With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds