Re: [PATCH 08/14] pwm: meson: add the per-channel register offsets and bits in a struct

From: Martin Blumenstingl
Date: Mon May 27 2019 - 14:00:57 EST


Hi Neil,

On Mon, May 27, 2019 at 2:28 PM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
[...]
> This looks a little over-engineered, but it's correct :
my main motivation was to "not copy the 20 line switch/case statement
from meson_pwm_enable() to meson_pwm_get_state()"
I extended the idea that already existed for the "mux_reg_shifts"
array and made it work for "more than one value"

please speak up if you have another idea in mind, maybe that makes the
result even better


Martin