Re: [PATCH v3 7/9] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers

[Dan Murphy]

Rob

On 5/24/19 3:50 PM, Rob Herring wrote:
> On Thu, 23 May 2019 14:08:18 -0500, Dan Murphy wrote:
> > Introduce the bindings for the Texas Instruments LP5036, LP5030, LP5024 and
> > LP5018 RGB LED device driver.  The LP5036/30/24/18 can control RGB LEDs
> > individually or as part of a control bank group.  These devices have the ability
> > to adjust the mixing control for the RGB LEDs to obtain different colors
> > independent of the overall brightness of the LED grouping.
> >
> > Datasheet:
> > http://www.ti.com/lit/ds/symlink/lp5024.pdf
> > http://www.ti.com/lit/ds/symlink/lp5036.pdf
> >
> > Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> > ---
> >   .../devicetree/bindings/leds/leds-lp50xx.txt  | 142 ++++++++++++++++++
> >   1 file changed, 142 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/leds/leds-lp50xx.txt
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.

I usually provide the tags but in my cover letter I did indicate that 
these patchsets have changed pretty dramatically so I did not feel right 
about pulling in anyones tags.

Adding your reviewed by on a binding that changed did not seem right to me.

Dan