Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524

[Daniel Baluta]

On Mon, May 20, 2019 at 10:33 PM Fabio Estevam <festevam@xxxxxxxxx> wrote:
>
> On Thu, May 16, 2019 at 3:35 PM Fabio Estevam <festevam@xxxxxxxxx> wrote:
> >
> > On Wed, May 15, 2019 at 11:42 AM Daniel Baluta <daniel.baluta@xxxxxxx> wrote:
> >
> > > +               simple-audio-card,codec {
> > > +                       sound-dai = <&wm8524>;
> > > +                       clocks = <&clk IMX8MM_CLK_SAI3_ROOT>;
> >
> > IMX8MM_CLK_SAI3_ROOT is the internal clock that drives the SAI3
> > interface, not an external clock that feeds the codec.
> >
> > It seems you should remove this 'clocks' entry.
>
> Just checked the schematics and the SAI3_MCLK pin clocks the codec, so
> the representation is correct:
>
> Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>

Shawn,

Can you have a look?