Re: [PATCH] scripts/decode_stacktrace.sh: prefix addr2line with $CROSS_COMPILE

[Konstantin Khlebnikov]

On 27.05.2019 11:34, Manuel Traut wrote:
> At least for ARM64 kernels compiled with the crosstoolchain from
> Debian/stretch or with the toolchain from kernel.org the line number is not
> decoded correctly by 'decode_stacktrace.sh':
>
> $ echo "[  136.513051]  f1+0x0/0xc [kcrash]" | \
>    CROSS_COMPILE=/opt/gcc-8.1.0-nolibc/aarch64-linux/bin/aarch64-linux- \
>   ./scripts/decode_stacktrace.sh /scratch/linux-arm64/vmlinux \
>                                  /scratch/linux-arm64 \
>                                  /nfs/debian/lib/modules/4.20.0-devel
> [  136.513051] f1 (/linux/drivers/staging/kcrash/kcrash.c:68) kcrash
>
> If addr2line from the toolchain is used the decoded line number is correct:
>
> [  136.513051] f1 (/linux/drivers/staging/kcrash/kcrash.c:57) kcrash
>
> Signed-off-by: Manuel Traut <manut@xxxxxxxxxxxxx>

Acked-by: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxxxxxx>


> ---
>   scripts/decode_stacktrace.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
> index bcdd45df3f51..a7a36209a193 100755
> --- a/scripts/decode_stacktrace.sh
> +++ b/scripts/decode_stacktrace.sh
> @@ -73,7 +73,7 @@ parse_symbol() {
>   	if [[ "${cache[$module,$address]+isset}" == "isset" ]]; then
>   		local code=${cache[$module,$address]}
>   	else
> -		local code=$(addr2line -i -e "$objfile" "$address")
> +		local code=$(${CROSS_COMPILE}addr2line -i -e "$objfile" "$address")
>   		cache[$module,$address]=$code
>   	fi
>