Re: [PATCH 2/7] sched/fair: Replace source_load() & target_load() w/ weighted_cpuload()

From: Dietmar Eggemann
Date: Tue May 28 2019 - 06:28:19 EST


On 5/28/19 6:42 AM, Hillf Danton wrote:

On Mon, 27 May 2019 07:21:11 +0100 Dietmar Eggemann wrote:

[...]

@@ -5500,7 +5464,7 @@ wake_affine_weight(struct sched_domain *sd, struct task_struct *p,
this_eff_load *= 100;
this_eff_load *= capacity_of(prev_cpu);
- prev_eff_load = source_load(prev_cpu, sd->wake_idx);
+ prev_eff_load = weighted_cpuload(cpu_rq(this_cpu));
cpu_rq(prev_cpu)

Seems we have no need to see this cpu's load more than once.

Thanks for catching this! Will fix it in v2.