Re: [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition

[Dan Murphy]

Pavel

On 5/27/19 7:45 PM, Dan Murphy wrote:
> Pavel
>
> On 5/27/19 5:33 AM, Pavel Machek wrote:
> > On Thu 2019-05-23 14:08:12, Dan Murphy wrote:
> > > Add a documentation of LED Multicolor LED class specific
> > > sysfs attributes.
> > >
> > > Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> > > ---
> > >   .../ABI/testing/sysfs-class-led-multicolor    | 57 
> > > +++++++++++++++++++
> > >   1 file changed, 57 insertions(+)
> > >   create mode 100644 
> > > Documentation/ABI/testing/sysfs-class-led-multicolor
> > >
> > > diff --git a/Documentation/ABI/testing/sysfs-class-led-multicolor 
> > > b/Documentation/ABI/testing/sysfs-class-led-multicolor
> > > new file mode 100644
> > > index 000000000000..2f102ede258b
> > > --- /dev/null
> > > +++ b/Documentation/ABI/testing/sysfs-class-led-multicolor
> > > @@ -0,0 +1,57 @@
> > > +What:        /sys/class/leds/<led>/colors/sync_enable
> > > +Date:        April 2019
> > I believe I suggested more reasonable interface. Why not use that?
>
> Can you please provide the reference to your interface?
I think I found the suggestion [0].  Assuming that was the suggestion it 
violates the kernel 1 value/file and there was agreement that this 
interface had value. In testing the interface, it made sense to be able 
to setup a color after writing each color brightness file and then 
syncing the color LEDs with the new brightness levels.  It also provides 
flexibility to be able to set a single LED color without writing sync.  
The decision to do either or should really be a user space decision.   
If I have referenced the wrong thread please let me know which thread 
you are referring to.

[0] https://lore.kernel.org/patchwork/patch/1057044/

<snip>

Dan