Re: test VIDIOC_G/S_PARM: FAIL on stable 4.14, 4.9 and 4.4

[Naresh Kamboju]

Hi Hans,

On Tue, 28 May 2019 at 17:27, Hans Verkuil <hverkuil-cisco@xxxxxxxxx> wrote:
> >>>> Do you see test VIDIOC_G/S_PARM: FAIL on stable 4.14, 4.9 and 4.4
> >>>> kernel branches ?
> >>>
> >>> Probably related to commit 8a7c5594c0202 (media: v4l2-ioctl: clear fields in s_parm).
> >>
> >> I have cherry-picked on stable rc 4.9 branch and tested and test got
> >> PASS on x86_64.
> >
> > I have cherry-picked for stable -rc 4.14 and 4.9 and test got PASS.
>
> Just to be clear: you cherry-picked commit 8a7c5594c0202 (media: v4l2-ioctl: clear
> fields in s_parm) for both 4.9 and 4.14, right?

Right.

>
> If so, feel free to post that patch to the stable mailinglist for those kernels.
> Make sure you CC me when you do that.

Alright I will do that.

> > do you want to queue this for stable rc 4.14 and 4.9 ?
> >
> > I have tested for 4.4 with patch applied but failed with below error.
> >
> > test VIDIOC_G/S_PARM: FAIL
>
> You probably need commit f63998331935 ([media] vivid: set V4L2_CAP_TIMEPERFRAME)
> and possibly commit 3f122df4a2ba (media: vivid: do not implement VIDIOC_S_PARM for output streams).

Thanks for suggesting few more patches.
I will apply these patches and test.

- Naresh