Re: [PATCH] trace: Avoid memory leak in predicate_parse()

From: Steven Rostedt
Date: Tue May 28 2019 - 11:33:22 EST


On Tue, 28 May 2019 17:18:59 +0200
Tomas Bortoli <tomasbortoli@xxxxxxxxx> wrote:

> >> + memset(prog_stack, 0, nr_preds * sizeof(*prog_stack));
> >> +
> >
> > Can you instead just switch the allocation of prog_stack to use
> > kcalloc()?
>
> kmalloc_array() is safe against arithmetic overflow of the arguments.
> Using kcalloc() directly we wouldn't check for that. Not really ideal in
> my opinion. And there's no kcalloc_array() apparently!

But doesn't kcalloc() simply call kmalloc_array() with the GFP_ZERO
flag?

-- Steve