[PATCH 1/3] lib/test_kasan: Add bitops tests

From: Marco Elver
Date: Tue May 28 2019 - 12:36:42 EST


This adds bitops tests to the test_kasan module. In a follow-up patch,
support for bitops instrumentation will be added.

Signed-off-by: Marco Elver <elver@xxxxxxxxxx>
---
lib/test_kasan.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 70 insertions(+), 3 deletions(-)

diff --git a/lib/test_kasan.c b/lib/test_kasan.c
index 7de2702621dc..f67f3b52251d 100644
--- a/lib/test_kasan.c
+++ b/lib/test_kasan.c
@@ -11,16 +11,17 @@

#define pr_fmt(fmt) "kasan test: %s " fmt, __func__

+#include <linux/bitops.h>
#include <linux/delay.h>
+#include <linux/kasan.h>
#include <linux/kernel.h>
-#include <linux/mman.h>
#include <linux/mm.h>
+#include <linux/mman.h>
+#include <linux/module.h>
#include <linux/printk.h>
#include <linux/slab.h>
#include <linux/string.h>
#include <linux/uaccess.h>
-#include <linux/module.h>
-#include <linux/kasan.h>

/*
* Note: test functions are marked noinline so that their names appear in
@@ -623,6 +624,71 @@ static noinline void __init kasan_strings(void)
strnlen(ptr, 1);
}

+static noinline void __init kasan_bitops(void)
+{
+ long bits = 0;
+ const long bit = sizeof(bits) * 8;
+
+ pr_info("within-bounds in set_bit");
+ set_bit(0, &bits);
+
+ pr_info("within-bounds in set_bit");
+ set_bit(bit - 1, &bits);
+
+ pr_info("out-of-bounds in set_bit\n");
+ set_bit(bit, &bits);
+
+ pr_info("out-of-bounds in __set_bit\n");
+ __set_bit(bit, &bits);
+
+ pr_info("out-of-bounds in clear_bit\n");
+ clear_bit(bit, &bits);
+
+ pr_info("out-of-bounds in __clear_bit\n");
+ __clear_bit(bit, &bits);
+
+ pr_info("out-of-bounds in clear_bit_unlock\n");
+ clear_bit_unlock(bit, &bits);
+
+ pr_info("out-of-bounds in __clear_bit_unlock\n");
+ __clear_bit_unlock(bit, &bits);
+
+ pr_info("out-of-bounds in change_bit\n");
+ change_bit(bit, &bits);
+
+ pr_info("out-of-bounds in __change_bit\n");
+ __change_bit(bit, &bits);
+
+ pr_info("out-of-bounds in test_and_set_bit\n");
+ test_and_set_bit(bit, &bits);
+
+ pr_info("out-of-bounds in __test_and_set_bit\n");
+ __test_and_set_bit(bit, &bits);
+
+ pr_info("out-of-bounds in test_and_set_bit_lock\n");
+ test_and_set_bit_lock(bit, &bits);
+
+ pr_info("out-of-bounds in test_and_clear_bit\n");
+ test_and_clear_bit(bit, &bits);
+
+ pr_info("out-of-bounds in __test_and_clear_bit\n");
+ __test_and_clear_bit(bit, &bits);
+
+ pr_info("out-of-bounds in test_and_change_bit\n");
+ test_and_change_bit(bit, &bits);
+
+ pr_info("out-of-bounds in __test_and_change_bit\n");
+ __test_and_change_bit(bit, &bits);
+
+ pr_info("out-of-bounds in test_bit\n");
+ (void)test_bit(bit, &bits);
+
+#if defined(clear_bit_unlock_is_negative_byte)
+ pr_info("out-of-bounds in clear_bit_unlock_is_negative_byte\n");
+ clear_bit_unlock_is_negative_byte(bit, &bits);
+#endif
+}
+
static int __init kmalloc_tests_init(void)
{
/*
@@ -664,6 +730,7 @@ static int __init kmalloc_tests_init(void)
kasan_memchr();
kasan_memcmp();
kasan_strings();
+ kasan_bitops();

kasan_restore_multi_shot(multishot);

--
2.22.0.rc1.257.g3120a18244-goog