RE: [v4, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

From: Jose Abreu
Date: Wed May 29 2019 - 03:43:27 EST


From: Biao Huang <biao.huang@xxxxxxxxxxxx>
Date: Wed, May 29, 2019 at 02:38:44

> } else if (!netdev_mc_empty(dev)) {
> - u32 mc_filter[2];
> + u32 mc_filter[8];
> struct netdev_hw_addr *ha;

The reverse christmas tree also applies here.

I also see some coding-style errors, like missing line breaks, etc...
that checkpatch should complain about.

Also, please run this patch against stmmac selftests and add the output
to the commit log.

Thanks,
Jose Miguel Abreu