Re: [PATCH 4/5] ALSA: fireface: Use ULL suffixes for 64-bit constants

[Takashi Iwai]

On Wed, 29 May 2019 11:57:31 +0200,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On Tue, May 28, 2019 at 04:24:23PM +0200, Geert Uytterhoeven wrote:
> > With gcc 4.1:
> > 
> >     sound/firewire/fireface/ff-protocol-latter.c: In function âlatter_switch_fetching_modeâ:
> >     sound/firewire/fireface/ff-protocol-latter.c:97: warning: integer constant is too large for âlongâ type
> >     sound/firewire/fireface/ff-protocol-latter.c: In function âlatter_begin_sessionâ:
> >     sound/firewire/fireface/ff-protocol-latter.c:170: warning: integer constant is too large for âlongâ type
> >     sound/firewire/fireface/ff-protocol-latter.c:197: warning: integer constant is too large for âlongâ type
> >     sound/firewire/fireface/ff-protocol-latter.c:205: warning: integer constant is too large for âlongâ type
> >     sound/firewire/fireface/ff-protocol-latter.c: In function âlatter_finish_sessionâ:
> >     sound/firewire/fireface/ff-protocol-latter.c:214: warning: integer constant is too large for âlongâ type
> > 
> > Fix this by adding the missing "ULL" suffixes.
> > Add the same suffix to the last constant, to maintain consistency.
> > 
> > Fixes: fd1cc9de64c2ca6c ("ALSA: fireface: add support for Fireface UCX")
> > Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > ---
> >  sound/firewire/fireface/ff-protocol-latter.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> Thanks for your care.
> 
> Reviewed-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>

Applied to sound git tree now.  Thanks.


Takashi