Re: [PATCH 1/2 v3] serial: mctrl_gpio: Check if GPIO property exisits before requesting it

[Stefan Roese]

On 29.05.19 15:44, Johan Hovold wrote:
> On Mon, May 27, 2019 at 01:18:04PM +0200, Stefan Roese wrote:
> > This patch adds a check for the GPIOs property existence, before the
> > GPIO is requested. This fixes an issue seen when the 8250 mctrl_gpio
> > support is added (2nd patch in this patch series) on x86 platforms using
> > ACPI.
>
> > Signed-off-by: Stefan Roese <sr@xxxxxxx>
> > Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Cc: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Cc: Giulio Benetti <giulio.benetti@xxxxxxxxxxxxxxxx>
> > ---
> > v3:
> > - No change
> >
> > v2:
> > - Include the problem description and analysis from Mika into the commit
> >    text, as suggested by Greg.
> >
> >   drivers/tty/serial/serial_mctrl_gpio.c | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
> > index 39ed56214cd3..cac50b20a119 100644
> > --- a/drivers/tty/serial/serial_mctrl_gpio.c
> > +++ b/drivers/tty/serial/serial_mctrl_gpio.c
> > @@ -116,6 +116,13 @@ struct mctrl_gpios *mctrl_gpio_init_noauto(struct device *dev, unsigned int idx)
> >   
> >   	for (i = 0; i < UART_GPIO_MAX; i++) {
> >   		enum gpiod_flags flags;
> > +		char *gpio_str;
> > +
> > +		/* Check if GPIO property exists and continue if not */
> > +		gpio_str = kasprintf(GFP_KERNEL, "%s-gpios",
> > +				     mctrl_gpios_desc[i].name);
>
> Where's the corresponding kfree?

Its missing. I'll add it in v4.

Thanks,
Stefan