Re: [PATCH v2] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

From: Peter Zijlstra
Date: Wed May 29 2019 - 13:04:29 EST


On Wed, May 29, 2019 at 06:26:59PM +0200, Jiri Kosina wrote:
> On Wed, 29 May 2019, Josh Poimboeuf wrote:

> > Is there are reason why maxcpus= doesn't do the CR4.MCE booted_once
> > dance?
>
> I am not sure whether it's really needed. My understanding is that the MCE
> issue happens only after primary sibling has been brought up; if that
> never happened, MCE wouldn't be broadcasted to that core at all in the
> first place.
>
> But this needs to be confirmed by Intel.

(I'm not confirming anything, as I've no clue), but that code stems from
long before we found out about that brilliant MCE stuff (which was
fairly recent).