Re: [PATCH 3/7] vfs: Add a mount-notification facility
From: Casey Schaufler
Date: Wed May 29 2019 - 13:50:01 EST
On 5/29/2019 10:13 AM, Andy Lutomirski wrote:
>> On May 29, 2019, at 8:53 AM, Casey Schaufler <casey@xxxxxxxxxxxxxxxx> wrote:
>>> On 5/29/2019 4:00 AM, David Howells wrote:
>>> Jann Horn <jannh@xxxxxxxxxx> wrote:
>>>>> +void post_mount_notification(struct mount *changed,
>>>>> + struct mount_notification *notify)
>>>>> + const struct cred *cred = current_cred();
>>>> This current_cred() looks bogus to me. Can't mount topology changes
>>>> come from all sorts of places? For example, umount_mnt() from
>>>> umount_tree() from dissolve_on_fput() from __fput(), which could
>>>> happen pretty much anywhere depending on where the last reference gets
>>> IIRC, that's what Casey argued is the right thing to do from a security PoV.
>> You need to identify the credential of the subject that triggered
>> the event. If it isn't current_cred(), the cred needs to be passed
>> in to post_mount_notification(), or derived by some other means.
> Taking a step back, why do we care who triggered the event? It seems to me that we should care whether the event happened and whether the *receiver* is permitted to know that.
There are two filesystems, "dot" and "dash". I am not allowed
to communicate with Fred on the system, and all precautions have
been taken to ensure I cannot. Fred asks for notifications on
all mount activity. I perform actions that result in notifications
on "dot" and "dash". Fred receives notifications and interprets
them using Morse code. This is not OK. If Wilma, who *is* allowed
to communicate with Fred, does the same actions, he should be
allowed to get the messages via Morse.
The event is information. The information is generated as a
result of my or Wilma's action. Fred is passive in this access.
Fred is not "reading" the event. The event is being written to
Fred. My process is the subject, and Fred's the object.
Other security modelers may disagree. The models they produce
are going to be *very* complicated and will introduce agents and
intermediate objects to justify Fred's reception of an event as
a read operation.
> (And receiver means whoever subscribed, presumably, not whoever called read() or mmap().)
The receiver is the process that gets the event. There may
be more than one receiver, and the receivers may have different
credentials. Each needs to be checked separately.
Isn't this starting to sound like the discussions on kdbus?
I'm not sure if that deserves a :) or a :( but probably one of the two.