Re: [PATCH AUTOSEL 5.0 095/317] mlxsw: spectrum_router: Prevent ipv6 gateway with v4 route via replace and append

[Sasha Levin]

On Wed, May 22, 2019 at 01:27:41PM -0600, David Ahern wrote:
> On 5/22/19 1:19 PM, Sasha Levin wrote:
> > From: David Ahern <dsahern@xxxxxxxxx>
> >
> > [ Upstream commit 7973d9e76727aa42f0824f5569e96248a572d50b ]
> >
> > mlxsw currently does not support v6 gateways with v4 routes. Commit
> > 19a9d136f198 ("ipv4: Flag fib_info with a fib_nh using IPv6 gateway")
> > prevents a route from being added, but nothing stops the replace or
> > append. Add a catch for them too.
> >     $ ip  ro add 172.16.2.0/24 via 10.99.1.2
> >     $ ip  ro replace 172.16.2.0/24 via inet6 fe80::202:ff:fe00:b dev swp1s0
> >     Error: mlxsw_spectrum: IPv6 gateway with IPv4 route is not supported.
> >     $ ip  ro append 172.16.2.0/24 via inet6 fe80::202:ff:fe00:b dev swp1s0
> >     Error: mlxsw_spectrum: IPv6 gateway with IPv4 route is not supported.
> >
> > Signed-off-by: David Ahern <dsahern@xxxxxxxxx>
> > Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > ---
> >  drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 ++
> >  1 file changed, 2 insertions(+)
>
> Not needed for 5.0. IPv6 nexthops with an IPv4 gateway is a 5.2 feature.

Dropped, thanks!

--
Thanks,
Sasha