Re: [PATCH] Revert "usb: dwc2: host: Setting qtd to NULL after freeing it"

From: Doug Anderson
Date: Wed May 29 2019 - 17:04:28 EST


Hi,

On Wed, May 29, 2019 at 1:54 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> This reverts commit b0d659022e5c96ee5c4bd62d22d3da2d66de306b.
>
> The reverted commit does nothing but adding two unnecessary lines
> of code. It sets a local variable to NULL in two functions, but
> that variable is not used anywhere in the rest of those functions.
> This is just confusing, so let's remove it.
>
> Cc: Vardan Mikayelyan <mvardan@xxxxxxxxxxxx>
> Cc: John Youn <johnyoun@xxxxxxxxxxxx>
> Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Cc: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> drivers/usb/dwc2/hcd.c | 1 -
> drivers/usb/dwc2/hcd.h | 1 -
> 2 files changed, 2 deletions(-)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>