Re: [Patch v2] wd719x: pass GFP_ATOMIC instead of GFP_KERNEL

From: David Rientjes
Date: Wed May 29 2019 - 17:16:52 EST


On Wed, 29 May 2019, Hariprasad Kelam wrote:

> dont acquire lock before calling wd719x_chip_init.
>
> Issue identified by coccicheck
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@xxxxxxxxx>
> -----
> changes in v1: Replace GFP_KERNEL with GFP_ATOMIC.
> changes in v2: Call wd719x_chip_init without lock as suggested
> in review

Why was host_lock taken here initially? I assume it's to protect some
race in init that leads to an undefined state.