RE: [PATCH 1/1] Drivers: hv: vmbus: Break out ISA independent parts of mshyperv.h

[Michael Kelley]

From: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> Sent: Wednesday, May 29, 2019 8:41 AM
> >  void __init hyperv_init(void);
> 
> I would actually expect to see hyperv_init() on all architectures so it
> can probably go to 'generic' too.
> 

Actually not.  The declaration is not needed on all architectures.   On ARM64,
hyperv_init() and ms_hyperv_init_platform() are folded into one routine, and
it's not externally referenced.  So the declaration isn't needed.  The hypervisor
initialization approach is fairly different on ARM64.

[....]
> 
> This seems a little bit too much, in particular, I think we don't need
> 
>  #include <linux/interrupt.h>
>  #include <linux/clocksource.h>
>  #include <linux/irq.h>
>  #include <linux/irqdesc.h>
> 
> we'll need 'struct pt_regs' definition but I'd suggest we use
> 
>  #include <linux/ptrace.h>
> 
> or even
> 
>  #include <asm/ptrace.h>
> 

Agreed.  I'll spin a v2 with this cleaned up.

Michael