RE: [PATCH 1/2] zstd: pass pointer rathen than structure to functions
From: Vaneet Narang
Date: Thu May 30 2019 - 05:20:22 EST
[Reminder] Any updates ?
> currentlyÂparamsÂstructureÂisÂpassedÂinÂallÂfunctions,ÂwhichÂincreases
> stackÂusageÂinÂallÂtheÂfunctionÂandÂleadÂtoÂstackÂoverflowÂonÂtargetÂlike
> ARMÂwithÂkernelÂstackÂsizeÂofÂ8ÂKBÂsoÂbetterÂtoÂpassÂpointer.
Â
> CheckedÂforÂARM:
Â
> (ZSTD_compressContinue_internal)->Â136ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ->Â88
> (ZSTD_compressCCtx)ÂÂÂÂÂÂÂÂÂÂÂÂÂ->Â192ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ->Â64
> (zstd_compress)ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ->Â144ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ->Â96
Regards,
Vaneet Narang