Re: [PATCH] crypto: jitterentropy - change back to module_init()

From: Herbert Xu
Date: Thu May 30 2019 - 09:46:28 EST


On Tue, May 21, 2019 at 11:46:22AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
>
> "jitterentropy_rng" doesn't have any other implementations, nor is it
> tested by the crypto self-tests. So it was unnecessary to change it to
> subsys_initcall. Also it depends on the main clocksource being
> initialized, which may happen after subsys_initcall, causing this error:
>
> jitterentropy: Initialization failed with host not compliant with requirements: 2
>
> Change it back to module_init().
>
> Fixes: c4741b230597 ("crypto: run initcalls for generic implementations earlier")
> Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> ---
> crypto/jitterentropy-kcapi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt