Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

From: Jiri Kosina
Date: Thu May 30 2019 - 19:45:47 EST


On Thu, 30 May 2019, Josh Poimboeuf wrote:

> > > Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> >
> > Yes, it is, thanks!
>
> I still think changing monitor/mwait to use a fixmap address would be a
> much cleaner way to fix this. I can try to work up a patch tomorrow.

I disagree with that from the backwards compatibility point of view.

I personally am quite frequently using differnet combinations of
resumer/resumee kernels, and I've never been biten by it so far. I'd guess
I am not the only one.
Fixmap sort of breaks that invariant.

Thanks,

--
Jiri Kosina
SUSE Labs