Re: [PATCH v2 00/17] perf tools: Coresight: Add CPU-wide trace support

From: Leo Yan
Date: Thu May 30 2019 - 21:49:31 EST


On Fri, May 24, 2019 at 11:34:51AM -0600, Mathieu Poirier wrote:
> This patchset adds support for CoreSight CPU-wide trace scenarios. More
> specifically it extends the work that was done for per thread scenarios to
> handle more than a single trace ID. It also temporally correlate traces
> based on timestamp generated by the tracers so that rendering by the perf
> mechanic is ordered.
>
> Everything is based on Arnaldo's perf/core branch (46d4c9a05285). I will
> send another revision when it is rebased to a 5.2 rc candidate.
>
> Before this set:
> # root@juno:/home/linaro# perf record -e cs_etm/@20070000.etr/ -C 2,3 sleep 1
> failed to mmap with 12 (Cannot allocate memory)
>
> After this set:
> # root@juno:/home/linaro# perf record -e cs_etm/@20070000.etr/ -C 2,3 sleep 1
> [ perf record: Captured and wrote 1.352 MB perf.data ]

I have tested this patch set on Juno and DB410c boards, FWIW:

Tested-by: Leo Yan <leo.yan@xxxxxxxxxx>

> Regards,
> Mathieu
>
> Changes for V2:
> * Fixed error condition in function cs_etm_set_option() (Leo)
> * Fixed changelog spelling error (Leo).
> * Moved from calloc() to malloc() in cs_etm__etmq_get_traceid_queue()
> * Got rid of CS_ETM_PACKET_QUEUE_NR macro
> * Fixed indentation problem in function cs_etm__process_traceid_queue() (Leo).
>
> Mathieu Poirier (17):
> perf tools: Configure contextID tracing in CPU-wide mode
> perf tools: Configure timestsamp generation in CPU-wide mode
> perf tools: Configure SWITCH_EVENTS in CPU-wide mode
> perf tools: Add handling of itrace start events
> perf tools: Add handling of switch-CPU-wide events
> perf tools: Refactor error path in cs_etm_decoder__new()
> perf tools: Move packet queue out of decoder structure
> perf tools: Fix indentation in function
> cs_etm__process_decoder_queue()
> perf tools: Introduce the concept of trace ID queues
> perf tools: Get rid of unused cpu in struct cs_etm_queue
> perf tools: Move thread to traceid_queue
> perf tools: Move tid/pid to traceid_queue
> perf tools: Use traceID aware memory callback API
> perf tools: Add support for multiple traceID queues
> perf tools: Linking PE contextID with perf thread mechanic
> perf tools: Add notion of time to decoding code
> perf tools: Add support for CPU-wide trace scenarios
>
> tools/perf/Makefile.config | 3 +
> tools/perf/arch/arm/util/cs-etm.c | 186 ++-
> .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 269 +++--
> .../perf/util/cs-etm-decoder/cs-etm-decoder.h | 39 +-
> tools/perf/util/cs-etm.c | 1026 +++++++++++++----
> tools/perf/util/cs-etm.h | 103 ++
> 6 files changed, 1252 insertions(+), 374 deletions(-)
>
> --
> 2.17.1
>