RE: [PATCH v6 07/10] usb: roles: Add fwnode_usb_role_switch_get() function
From: Biju Das
Date: Fri May 31 2019 - 03:46:19 EST
Hi,
Thanks for the patch.
> Subject: [PATCH v6 07/10] usb: roles: Add fwnode_usb_role_switch_get()
> function
>
> From: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
>
> The fwnode_usb_role_switch_get() function is exactly the same as
> usb_role_switch_get(), except that it takes struct fwnode_handle as
> parameter instead of struct device.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
Tested-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> ---
> v6:
> new patch
> ---
> drivers/usb/roles/class.c | 20 ++++++++++++++++++++
> include/linux/usb/role.h | 7 +++++++
> 2 files changed, 27 insertions(+)
>
> diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c index
> f45d8df5cfb8..aab795b54c7f 100644
> --- a/drivers/usb/roles/class.c
> +++ b/drivers/usb/roles/class.c
> @@ -135,6 +135,26 @@ struct usb_role_switch *usb_role_switch_get(struct
> device *dev) } EXPORT_SYMBOL_GPL(usb_role_switch_get);
>
> +/**
> + * fwnode_usb_role_switch_get - Find USB role switch linked with the
> +caller
> + * @fwnode: The caller device node
> + *
> + * This is similar to the usb_role_switch_get() function above, but it
> +searches
> + * the switch using fwnode instead of device entry.
> + */
> +struct usb_role_switch *fwnode_usb_role_switch_get(struct
> fwnode_handle
> +*fwnode) {
> + struct usb_role_switch *sw;
> +
> + sw = fwnode_connection_find_match(fwnode, "usb-role-switch",
> NULL,
> + usb_role_switch_match);
> + if (!IS_ERR_OR_NULL(sw))
> + WARN_ON(!try_module_get(sw->dev.parent->driver-
> >owner));
> +
> + return sw;
> +}
> +EXPORT_SYMBOL_GPL(fwnode_usb_role_switch_get);
> +
> /**
> * usb_role_switch_put - Release handle to a switch
> * @sw: USB Role Switch
> diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h index
> da2b9641b877..2d77f97df72d 100644
> --- a/include/linux/usb/role.h
> +++ b/include/linux/usb/role.h
> @@ -47,6 +47,7 @@ struct usb_role_switch_desc { int
> usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role);
> enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw);
> struct usb_role_switch *usb_role_switch_get(struct device *dev);
> +struct usb_role_switch *fwnode_usb_role_switch_get(struct
> fwnode_handle
> +*node);
> void usb_role_switch_put(struct usb_role_switch *sw);
>
> struct usb_role_switch *
> @@ -70,6 +71,12 @@ static inline struct usb_role_switch
> *usb_role_switch_get(struct device *dev)
> return ERR_PTR(-ENODEV);
> }
>
> +static inline struct usb_role_switch *
> +fwnode_usb_role_switch_get(struct fwnode_handle *node) {
> + return ERR_PTR(-ENODEV);
> +}
> +
> static inline void usb_role_switch_put(struct usb_role_switch *sw) { }
>
> static inline struct usb_role_switch *
> --
> 2.21.0