Re: [PATCH] PM / clk: Remove error message on out-of-memory condition

[Rafael J. Wysocki]

On Monday, May 27, 2019 2:27:51 PM CEST Geert Uytterhoeven wrote:
> There is no need to print an error message if kstrdup() fails, as the
> memory allocation core already takes care of that.
> 
> Note that commit 59d84ca8c46a93ad ("PM / OPP / clk: Remove unnecessary
> OOM message") already removed similar error messages, but this one was
> forgotten.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
>  drivers/base/power/clock_ops.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c
> index 59d19dd649289287..1cf86fcaeff8faac 100644
> --- a/drivers/base/power/clock_ops.c
> +++ b/drivers/base/power/clock_ops.c
> @@ -92,8 +92,6 @@ static int __pm_clk_add(struct device *dev, const char *con_id,
>  	if (con_id) {
>  		ce->con_id = kstrdup(con_id, GFP_KERNEL);
>  		if (!ce->con_id) {
> -			dev_err(dev,
> -				"Not enough memory for clock connection ID.\n");
>  			kfree(ce);
>  			return -ENOMEM;
>  		}
> 

Applied, thanks!