Re: [PATCH] staging: comedi: Remove variable runflags

[Ian Abbott]

On 30/05/2019 21:51, Nishka Dasgupta wrote:
> Remove variable runflags and use its value directly. Issue found with
> checkpatch.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@xxxxxxxxx>
> ---
>   drivers/staging/comedi/comedi_fops.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index f6d1287c7b83..b84ee9293903 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -676,16 +676,12 @@ EXPORT_SYMBOL_GPL(comedi_is_subdevice_running);
>   
>   static bool __comedi_is_subdevice_running(struct comedi_subdevice *s)
>   {
> -	unsigned int runflags = __comedi_get_subdevice_runflags(s);
> -
> -	return comedi_is_runflags_running(runflags);
> +	return comedi_is_runflags_running(__comedi_get_subdevice_runflags(s));
>   }
>   
>   bool comedi_can_auto_free_spriv(struct comedi_subdevice *s)
>   {
> -	unsigned int runflags = __comedi_get_subdevice_runflags(s);
> -
> -	return runflags & COMEDI_SRF_FREE_SPRIV;
> +	return __comedi_get_subdevice_runflags(s) & COMEDI_SRF_FREE_SPRIV;
>   }
>   
>   /**

I couldn't reproduce this checkpatch issue, even with '--subjective'.

--
-=( Ian Abbott <abbotti@xxxxxxxxx> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-