Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume
From: Pavel Machek
Date: Fri May 31 2019 - 08:22:04 EST
On Fri 2019-05-31 01:42:02, Jiri Kosina wrote:
> On Thu, 30 May 2019, Josh Poimboeuf wrote:
>
> > > > Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > >
> > > Yes, it is, thanks!
> >
> > I still think changing monitor/mwait to use a fixmap address would be a
> > much cleaner way to fix this. I can try to work up a patch tomorrow.
>
> I disagree with that from the backwards compatibility point of view.
>
> I personally am quite frequently using differnet combinations of
> resumer/resumee kernels, and I've never been biten by it so far. I'd guess
> I am not the only one.
> Fixmap sort of breaks that invariant.
If we get less tricky code, it may be worth it...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature