Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

From: Jiri Kosina
Date: Fri May 31 2019 - 10:58:08 EST


On Fri, 31 May 2019, Andy Lutomirski wrote:

> For that matter, what actually happens if we get an SMI while halted?
> Does RSM go directly to sleep or does it re-fetch the HLT?

Our mails just crossed, I replied to Josh's mwait() proposal patch a
minute ago.

HLT is guaranteed to be re-entered if SMM interrupted it, while MWAIT is
not.

So as a short-term fix for 5.2, I still believe in v4 of my patch that
does the mwait->hlt->mwait transition across hibernate/resume, and for 5.3
I can look into forcing it to wait-for-SIPI proper.

--
Jiri Kosina
SUSE Labs