Re: [PATCH] clk: tegra210: Fix default rates for HDA clocks
From: Jon Hunter
Date: Fri May 31 2019 - 11:02:45 EST
On 29/05/2019 14:46, Thierry Reding wrote:
> On Wed, May 29, 2019 at 10:18:21AM +0100, Jon Hunter wrote:
>> Currently the default clock rates for the HDA and HDA2CODEC_2X clocks
>> are both 19.2MHz. However, the default rates for these clocks should
>> actually be 51MHz and 48MHz, respectively. Correct the default clock
>> rates for these clocks by specifying them in the clock init table for
>> Tegra210.
>>
>> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>
>> ---
>> drivers/clk/tegra/clk-tegra210.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> Does this fix anything? Should this be backported to stable releases?
Good point. We are aligning the clock configuration with what we ship.
So I thought for completeness it would be good to test HDA playback
across the various sample-rates we support (32kHz to 192kHz) but with or
without this patch I am not hearing anything. Let me check on this with
Sameer as I would like to see if we need to mark this for stable or not.
> Acked-by: Thierry Reding <treding@xxxxxxxxxx>
Thanks
Jon
--
nvpublic