Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0

From: Nikita Yushchenko
Date: Fri May 31 2019 - 11:06:05 EST


>> Kernel currently does, but it is caught in
>> mv88e6xxx_port_check_hw_vlan() and returns -ENOTSUPP from there.
>
> But VID 0 has a special meaning for the kernel, it means the port's private
> database (when it is isolated, non-bridged), it is not meant to be programmed
> in the switch. That's why I would've put that knowledge into the DSA layer,
> which job is to translate the kernel operations to the (dumb) DSA drivers.
>
> I hope I'm seeing things correctly here.

I'm ok with either solution.