Re: [PATCH v2 03/17] soc: qcom: ipa: main code

From: Alex Elder
Date: Fri May 31 2019 - 18:29:41 EST


On 5/31/19 4:50 PM, David Miller wrote:
> From: Alex Elder <elder@xxxxxxxxxx>
> Date: Thu, 30 May 2019 22:53:34 -0500
>
>> + void *route_virt;
> ...
>> + void *filter_virt;
> ...
>
> If these are arrays of u64's, please declare them as "u64 *" instead of
> the opaque "void *".

Good idea. I hadn't paid attention to that. These tables are
arrays of 64-bit addresses so it's better to represent them that
way.

Thanks.

-Alex