Re: [PATCH] crypto: ux500 - fix license comment syntax error

[Masahiro Yamada]

On Sun, Jun 2, 2019 at 4:41 AM Alex Xu <alex_y_xu@xxxxxxxx> wrote:
>
> Quoting Greg KH (2019-06-01 16:29:07)
> > On Sat, Jun 01, 2019 at 10:49:43AM -0400, Alex Xu (Hello71) wrote:
> > > Causes error: drivers/crypto/ux500/cryp/Makefile:5: *** missing
> > > separator.  Stop.
> > >
> > > Fixes: af873fcecef5 ("treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194")
> > > Signed-off-by: Alex Xu (Hello71) <alex_y_xu@xxxxxxxx>
> > > ---
> > >  drivers/crypto/ux500/cryp/Makefile | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Also, how did 0-day not catch this?  Is this an odd configuration that
> > it can not build?
>
> I had to run "make clean" to get the error.

I think this copyright block is ugly.


# SPDX-License-Identifier: GPL-2.0-only
#
# Copyright (C) ST-Ericsson SA 2010
# Author: shujuan.chen@xxxxxxxxxxxxxx for ST-Ericsson.

looks nicer IMHO.




-- 
Best Regards
Masahiro Yamada