Re: [GIT PULL] SPDX update for 5.2-rc3 - round 2

[Masahiro Yamada]

On Mon, Jun 3, 2019 at 2:15 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Sun, Jun 02, 2019 at 09:03:46PM +0900, Masahiro Yamada wrote:
> > On Sun, Jun 2, 2019 at 4:17 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > The following changes since commit 2f4c53349961c8ca480193e47da4d44fdb8335a8:
> > >
> > >   Merge tag 'spdx-5.2-rc3-1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core (2019-05-31 08:34:32 -0700)
> > >
> > > are available in the Git repository at:
> > >
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/spdx-5.2-rc3-2
> > >
> > > for you to fetch changes up to 8e82fe2ab65a80b1526b285c661ab88cc5891e3a:
> > >
> > >   treewide: fix typos of SPDX-License-Identifier (2019-06-01 18:29:58 +0200)
> > >
> > > ----------------------------------------------------------------
> > > SPDX fixes for 5.2-rc3, round 2
> > >
> > > Here are just two small patches, that fix up some found SPDX identifier
> > > issues.
> > >
> > > The first patch fixes an error in a previous SPDX fixup patch, that
> > > causes build errors when doing 'make clean' on the tree (the fact that
> > > almost no one noticed it reflects the fact that kernel developers don't
> > > like doing that option very often...)
> >
> > This paragraph is not precise.
> >
> > Not only "make clean", but also the normal build is broken.
> > In fact, ARCH=arm allmodconfig is broken.
> >
> >
> > $ make -j8 ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- allmodconfig
> >   [ snip ]
> > $ make -j8 ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
> >   [ snip ]
> > drivers/crypto/ux500/cryp/Makefile:5: *** missing separator.  Stop.
> > make[3]: *** [scripts/Makefile.build;489: drivers/crypto/ux500/cryp] Error 2
> > make[2]: *** [scripts/Makefile.build;489: drivers/crypto/ux500] Error 2
> > make[1]: *** [scripts/Makefile.build;489: drivers/crypto] Error 2
> > make[1]: *** Waiting for unfinished jobs....
> >
> >
> >
> > The 0-day bot should check allmodconfig for all arches,
> > but surprisingly it was not caught before the merge.
>
> Ah, good catch, odd that 0-day missed it.  Maybe it is not building
> 32bit builds these days :(


I noticed the SPDX patches were submitted to
linux-spdx@xxxxxxxxxxxxxxx
but not to linux-kernel@xxxxxxxxxxxxxxx

Maybe, the reason is why 0-day bot is not subscribing to
linux-spdx@xxxxxxxxxxxxxxx


You picked up them and sent a pull request immediately,
so the 0-day bot was not given time to test your branch either.



>> Not all developers run scripts/checkpatch.pl before patch submission.
>> Not all maintainers run scripts/checkpatch.pl before commit.
>
>Very true :(


If we really want to improve the situation,
perhaps can we ask Intel to run scripts/checkpatch.pl in the 0-day bot?

checkpatch.pl may warn false positives,
but at least "Missing or malformed SPDX-License-Identifier tag"
is a good checker.  Just my two cents.

-- 
Best Regards
Masahiro Yamada