Re: [PATCH -next] usb: host: ohci-st: Remove set but not used variable 'ohci'

From: Patrice CHOTARD
Date: Mon Jun 03 2019 - 04:57:48 EST


Hi

On 5/28/19 3:38 PM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/usb/host/ohci-st.c: In function st_ohci_platform_probe:
> drivers/usb/host/ohci-st.c:135:19: warning: variable ohci set but not used [-Wunused-but-set-variable]
>
> It's never used, so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> drivers/usb/host/ohci-st.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/host/ohci-st.c b/drivers/usb/host/ohci-st.c
> index 992807c9850a..638a92bd2cdc 100644
> --- a/drivers/usb/host/ohci-st.c
> +++ b/drivers/usb/host/ohci-st.c
> @@ -132,7 +132,6 @@ static int st_ohci_platform_probe(struct platform_device *dev)
> struct resource *res_mem;
> struct usb_ohci_pdata *pdata = &ohci_platform_defaults;
> struct st_ohci_platform_priv *priv;
> - struct ohci_hcd *ohci;
> int err, irq, clk = 0;
>
> if (usb_disabled())
> @@ -158,7 +157,6 @@ static int st_ohci_platform_probe(struct platform_device *dev)
> platform_set_drvdata(dev, hcd);
> dev->dev.platform_data = pdata;
> priv = hcd_to_ohci_priv(hcd);
> - ohci = hcd_to_ohci(hcd);
>
> priv->phy = devm_phy_get(&dev->dev, "usb");
> if (IS_ERR(priv->phy)) {
>

Acked-by: Patrice Chotard <patrice.chotard@xxxxxx>

Thanks