Re: [PATCH 02/10] arm64: dts: meson-gxm-khadas-vim2: fix Bluetooth support

[Christian Hewitt]

On 3 Jun 2019, at 12:57 pm, Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
> 
> On 29/05/2019 20:08, Martin Blumenstingl wrote:
>> On Wed, May 29, 2019 at 12:25 PM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
>>> 
>>> On 27/05/2019 20:36, Martin Blumenstingl wrote:
>>>> On Mon, May 27, 2019 at 3:22 PM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
>>>>> 
>>>>> From: Christian Hewitt <christianshewitt@xxxxxxxxx>
>>>>> 
>>>>> - Remove serial1 alias
>>>>> - Add support for uart_A rts/cts
>>>>> - Add bluetooth uart_A subnode qith shutdown gpio
>>>> I tried this on my own Khadas VIM2:
>>>> Bluetooth: hci0: command 0x1001 tx timeout
>>>> Bluetooth: hci0: BCM: Reading local version info failed (-110)
>>>> 
>>>> I'm not sure whether this is specific to my board or what causes this.
>>> 
>>> Which kernel version ?
>> 5.2-rc2
>> 
>> it's a Khadas VIM2 Basic (thus it has a AP6356S), board revision v1.2
> 
> Can you try with :
> 
> clocks = <&wifi32k>;
> clock-names = "lpo";
> 
> added in the bluetooth node ?

Tested and confirmed working with rev 1.2 âbasic' and 5.1 kernel with those nodes added.

VIM2:~ # dmesg | grep -i blue
[   10.793600] Bluetooth: Core ver 2.22
[   10.793792] Bluetooth: HCI device and connection manager initialized
[   10.793814] Bluetooth: HCI socket layer initialized
[   10.793821] Bluetooth: L2CAP socket layer initialized
[   10.793851] Bluetooth: SCO socket layer initialized
[   10.801928] Bluetooth: HCI UART driver ver 2.3
[   10.801944] Bluetooth: HCI UART protocol H4 registered
[   10.804919] Bluetooth: HCI UART protocol Broadcom registered
[   10.805025] Bluetooth: HCI UART protocol QCA registered
[   11.016629] Bluetooth: hci0: BCM: chip id 101
[   11.018537] Bluetooth: hci0: BCM: features 0x2f
[   11.043112] Bluetooth: hci0: BCM4354A2
[   11.043134] Bluetooth: hci0: BCM4356A2 (001.003.015) build 0000
[   11.075919] Bluetooth: Generic Bluetooth SDIO driver ver 0.1
[   11.359784] Bluetooth: BNEP (Ethernet Emulation) ver 1.3
[   11.359793] Bluetooth: BNEP filters: protocol multicast
[   11.359811] Bluetooth: BNEP socket layer initialized
[   17.075509] Bluetooth: hci0: BCM4356A2 (001.003.015) build 0266

I use BT remotes to avoid issues with multiple boards responding to IR so it was working before at some point. I assume I dropped a change somewhere in the process of feeding you the batch of patches - apologies!

Christian