Re: [PATCH net-next v5 3/5] net: stmmac: add xpcs function hooks into main driver and ethtool

[David Miller]

From: Voon Weifeng <weifeng.voon@xxxxxxxxx>
Date: Sat,  1 Jun 2019 03:58:12 +0800

> +static bool mac_adjust_link(struct stmmac_priv *priv,
> +			    int *speed, int *duplex)
> +{
> +	bool new_state = false;
> +
> +	u32 ctrl = readl(priv->ioaddr + MAC_CTRL_REG);

Again please don't break up the local variable declarations like this.