Re: [PATCH v4 00/16] NVIDIA Tegra devfreq improvements and Tegra20/30 support
From: Chanwoo Choi
Date: Mon Jun 03 2019 - 20:51:58 EST
On 19. 6. 4. ìì 1:52, Dmitry Osipenko wrote:
> 03.05.2019 3:52, Dmitry Osipenko ÐÐÑÐÑ:
>> 03.05.2019 3:31, Chanwoo Choi ÐÐÑÐÑ:
>>> Hi Dmitry,
>>>
>>> On 19. 5. 2. ìì 8:37, Dmitry Osipenko wrote:
>>>> Changelog:
>>>>
>>>> v4: Addressed all review comments that were made by Chanwoo Choi to v3:
>>>>
>>>> - changed the driver removal order to match the probe exactly
>>>> - added clarifying comment for 1/8 ratio to the Tegra20 driver
>>>>
>>>> Chanwoo, please also note that the clk patch that should fix
>>>> compilation problem that was reported the kbuild-test-robot is already
>>>> applied and available in the recent linux-next.
>>>
>>> I knew that Stephen picked up your path about clock.
>>
>> Hi Chanwoo,
>>
>> Okay, good. Thank you very much for reviewing this series! I assume it's
>> too late now for v5.2, but it should be good to go for v5.3.
>>
>
> Hello Chanwoo,
>
> Will be nice to see the patches in the linux-next before they'll hit mainline. We have tested that
> everything works fine on a selective devices, but won't hurt to get some extra testing beforehand.
> AFAIK, at least NVIDIA people are regularly testing -next on theirs dev boards. Please note that
> this not very important, so don't bother if there is some hurdle with pushing to the tracking branch
> for now. Also please let me know if you're expecting to see some ACK's on the patches, I'm sure
> we'll be able to work out that with Thierry and Jon if necessary.
>
>
Hi Dmitry,
I think that it is enough for applying to mainline branch.
The devfreq.git is maintained by Myungjoo. He will be merged or
reviewed if there are th remained review point.
Hi Myungjoo,
I reviewed the Dmitry's patches from v1 to v4 patches.
And then I tested them on my testing branch[1] for catching
the build warning and error. In result, it is clean.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/log/?h=devfreq-testing
Please review or apply these patches for v5.3.
--
Best Regards,
Chanwoo Choi
Samsung Electronics