Re: [PATCHv2 1/2] mm/gup: fix omission of check on FOLL_LONGTERM in get_user_pages_fast()

From: Pingfan Liu
Date: Tue Jun 04 2019 - 03:24:16 EST


On Tue, Jun 4, 2019 at 3:17 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> On Tue, Jun 04, 2019 at 03:13:21PM +0800, Pingfan Liu wrote:
> > Is it a convention? scripts/checkpatch.pl can not detect it. Could you
> > show me some light so later I can avoid it?
>
> If you look at most kernel code you can see two conventions:
>
> - double tabe indent
> - indent to the start of the first agument line
>
> Everything else is rather unusual.
OK.
Thanks