Re: [PATCH][next][V2] bpf: remove redundant assignment to err

From: Jesper Dangaard Brouer
Date: Tue Jun 04 2019 - 08:03:13 EST

On Tue, 4 Jun 2019 09:21:46 +0100
Colin King <colin.king@xxxxxxxxxxxxx> wrote:

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> The variable err is assigned with the value -EINVAL that is never
> read and it is re-assigned a new value later on. The assignment is
> redundant and can be removed.
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> V2: reorder variables as recommended by Jakub Kicinski to keep in
> the networking code style.

Thank you for following the networking coding style.

Acked-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>

Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat