RE:(2) [PATCH 0/4] zstd: reduce stack usage

From: Vaneet Narang
Date: Tue Jun 04 2019 - 08:34:09 EST


Hi Andrew,

>> This patch set reduces stack usage for zstd code, because target like ARM has
>> limited 8KB kernel stack, which is getting overflowed due to hight stack usage
>> of zstd code with call flow like:

>That's rather bad behaviour. I assume the patchset actually fixes this?

Yes, patchset tries to reduce around 300 bytes of stack usage of zstd compression path.
We faced high stack usage issue on switching compression algo from LZO/LZ4 to zstd algo.
zstd compression uses around 1200 bytes of stack which is huge as compared
to LZO/LZ4 which uses negligible stack (< 200 bytes).


>I think I'll schedule the patchset for 5.2-rcX so that zstd is actually
>usable on arm in 5.2. Does that sound OK?Â
OK

Regards,
Vaneet Narang