Re: [PATCH 01/22] perf intel-pt: Fix itrace defaults for perf script

From: Arnaldo Carvalho de Melo
Date: Tue Jun 04 2019 - 09:24:45 EST

Em Tue, Jun 04, 2019 at 02:32:15PM +0300, Adrian Hunter escreveu:
> On 31/05/19 7:45 PM, Arnaldo Carvalho de Melo wrote:
> > Em Mon, May 20, 2019 at 11:45:16AM -0300, Arnaldo Carvalho de Melo escreveu:
> >> Em Mon, May 20, 2019 at 02:37:07PM +0300, Adrian Hunter escreveu:
> >>> Commit 4eb068157121 ("perf script: Make itrace script default to all
> >>> calls") does not work because 'use_browser' is being used to determine
> >>> whether to default to periodic sampling (i.e. better for perf report).
> >>> The result is that nothing but CBR events display for perf script
> >>> when no --itrace option is specified.

> >>> Fix by using 'default_no_sample' and 'inject' instead.

> >> Applied 1-3 for now, concentrating on fixes, will process 4-22 later.

> > Tested the ones that affect sqlite databases an the GUI, all look good,
> > added committer notes and text screenshots as committer notes, thanks!

> Thanks for applying! Are patches 11-22 in your tree?

Yeah, delayed a bit push out as I was doing some automated tests, see
below what is there right now, if there is something missing, please let
me know, I also added commiter notes to most of them as I tested to see
if the comments matched the code and end GUI results.

- Arnaldo

ed1108bd8107 (HEAD -> perf/core, quaco/perf/core, acme/perf/core) perf augmented_raw_syscalls: Tell which args are filenames and how many bytes to copy
095b72ea8bc6 perf scripts python: Select find text when find bar is activated
08810ed07c90 perf scripts python: Add IPC information to Call Tree
96234e319dbe perf scripts python: Add IPC information to Call Graph Graph
18d0b3fa8f07 perf scripts python: Add CallGraphModelParams
a3f0fbba872e perf scripts python: Add IPC information to the Branch reports
44bd2140868f perf scripts python: Export IPC information
ea76f3ba4a25 perf scripts python: Export IPC information
75302e535b23 perf db-export: Export IPC information
a99d75fa022c perf db-export: Add brief documentation
0f9eea5e6974 perf thread-stack: Accumulate IPC information
1e80115f84a3 perf intel-pt: Document IPC usage
990917373744 perf intel-pt: Accumulate cycle count from TSC/TMA/MTC packets
17fa778da83e perf intel-pt: Re-factor TIP cases in intel_pt_walk_to_ip
dbb8dfd91a18 perf intel-pt: Record when decoding PSB+ packets
03386978a23b perf script: Add output of IPC ratio
f7c15a499e28 perf intel-pt: Add support for samples to contain IPC ratio
885ae6d43172 perf tools: Add IPC information to perf_sample
db3e60dd79a4 perf intel-pt: Accumulate cycle count from CYC packets
73a5a91c762d perf intel-pt: Factor out intel_pt_update_sample_time
3bbac0d75719 perf record: Allow mixing --user-regs with --call-graph=dwarf
7122f4bdb56d perf symbols: Remove unused variable 'err'
eea796aa2d6f perf data: Document directory format header: HEADER_DIR_FORMAT
cad909dc61fb perf data: Document clockid header: HEADER_CLOCKID
e1b3ce6a6898 perf data: Document memory topology header: HEADER_MEM_TOPOLOGY
8ab1ebfbb696 perf data: Add description of header HEADER_BPF_PROG_INFO and HEADER_BPF_BTF
b33fb3cf6f5e Merge tag 'perf-core-for-mingo-5.3-20190529' of git:// into perf/core
14f1cfd4f7b4 (tag: perf-core-for-mingo-5.3-20190529) perf intel-pt: Rationalize intel_pt_sync_switch()'s use of next_tid