RE:(2) [PATCH 1/4] zstd: pass pointer rathen than structure to functions
From: Vaneet Narang
Date: Tue Jun 04 2019 - 09:37:17 EST
Hi Andrew,
Â
>ButÂstructÂZSTD_CCtx_s.paramsÂisÂstillÂaÂcopiedÂstructure.ÂÂCouldÂwe
>makeÂitÂ`constÂZSTD_parametersÂ*params'?ÂÂProbablyÂnot,ÂdueÂtoÂlifetime
>issues?
ZSTD maintains its own ctxt. Yes we can avoid storing pointers of other modules
because of lifetime issues. We should keep ZSTD_CCtx_s.params as structure instead of pointer.
Thanks & Regards,
Vaneet Narang
Â
Â