Re: [linux-sunxi] [PATCH] clk: sunxi-ng: sun50i-h6-r: Fix incorrect W1 clock gate register

[Jernej Åkrabec]

Hi!

Dne torek, 04. junij 2019 ob 17:31:20 CEST je 'OndÅej Jirman' via linux-sunxi 
napisal(a):
> Hi Jernej,
> 
> On Tue, Jun 04, 2019 at 05:03:55PM +0200, Jernej Åkrabec wrote:
> > Dne torek, 04. junij 2019 ob 17:00:54 CEST je megous via linux-sunxi
> > 
> > napisal(a):
> > > From: Ondrej Jirman <megous@xxxxxxxxxx>
> > > 
> > > The current code defines W1 clock gate to be at 0x1cc, overlaying it
> > > with the IR gate.
> > > 
> > > Clock gate for r-apb1-w1 is at 0x1ec. This fixes issues with IR receiver
> > > causing interrupt floods on H6 (because interrupt flags can't be
> > > cleared,
> > > due to IR module's bus being disabled).
> > > 
> > > Signed-off-by: Ondrej Jirman <megous@xxxxxxxxxx>
> > 
> > You should add Fixes tag and CC stable with this.
> 
> Not necessary, since H6 IR is not yet supported on mainline.

Well, CCing stable is probably really not necessary, but you are fixing bug in 
existing driver (clk), fixes tag still apply.

Best regards,
Jernej

> 
> regards,
> 	o.
> 
> > Best regards,
> > Jernej
> > 
> > 
> > 
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel