Re: [PATCH] drm/nouveau/bios: downgrade absence of tmds table to info from an error

[Lyude Paul]

Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx>

On Sun, 2019-06-02 at 22:07 +1000, Rhys Kidd wrote:
> Absence of a TMDS Info Table is common on Optimus setups where the NVIDIA
> gpu is not connected directly to any outputs.
> 
> Reporting an error in this scenario is too harsh. Accordingly, change the
> error message to an info message.
> 
> By default the error message also causes a boot flicker for these sytems.
> 
> Signed-off-by: Rhys Kidd <rhyskidd@xxxxxxxxx>
> ---
>  drivers/gpu/drm/nouveau/nouveau_bios.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c
> b/drivers/gpu/drm/nouveau/nouveau_bios.c
> index 66bf2aff4a3e..bdfadc63204a 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> @@ -935,7 +935,7 @@ static int parse_bit_tmds_tbl_entry(struct drm_device
> *dev, struct nvbios *bios,
>  
>  	tmdstableptr = ROM16(bios->data[bitentry->offset]);
>  	if (!tmdstableptr) {
> -		NV_ERROR(drm, "Pointer to TMDS table invalid\n");
> +		NV_INFO(drm, "Pointer to TMDS table not found\n");
>  		return -EINVAL;
>  	}
>  
-- 
Cheers,
	Lyude Paul