Re: [PATCH] media: do not use C++ style comments in uapi headers
From: Joe Perches
Date: Wed Jun 05 2019 - 01:26:13 EST
On Wed, 2019-06-05 at 07:10 +0200, Greg KH wrote:
> On Wed, Jun 05, 2019 at 01:10:41PM +0900, Masahiro Yamada wrote:
> > On Wed, Jun 5, 2019 at 3:21 AM Arnd Bergmann <arnd@xxxxxxxx> wrote:
[]
> > This means we cannot reliably use uint{8,16,32,64}_t in UAPI headers.
>
> We should not be doing that as they are in the userspace "namespace" of
> variables, not in the kernel namespace. We've been over this many times
> in the past :(
Just not very successfully...
$ git grep -w -P 'u?_?int(?:8|16|32|64)_t' include/uapi | wc -l
342
$ git grep -w -P --name-only 'u?_?int(?:8|16|32|64)_t' include/uapi | wc -l
13
Documentation helps a bit, checkpatch helps as well.
Maintainer knowledge and vigilance probably helps the most.