Re: [PATCH] wimax: debug: fix a missing-check bug in d_parse_params()

[Jiri Slaby]

On 30. 05. 19, 11:39, Gen Zhang wrote:
> In d_parse_params(), 'params_orig' is allocated by kstrdup(). It returns
> NULL when fails. So 'params_orig' should be checked.
> 
> Signed-off-by: Gen Zhang <blackgod016574@xxxxxxxxx>
> ---
> diff --git a/include/linux/wimax/debug.h b/include/linux/wimax/debug.h
> index aaf24ba..bacd6cb 100644
> --- a/include/linux/wimax/debug.h
> +++ b/include/linux/wimax/debug.h
> @@ -496,6 +496,11 @@ void d_parse_params(struct d_level *d_level, size_t d_level_size,
>  	if (_params == NULL)
>  		return;
>  	params_orig = kstrdup(_params, GFP_KERNEL);
> +	if (!params_orig) {
> +		printk(KERN_ERR "%s: can't duplicate string '%s'\n",
> +		       tag, _params);

We use pr_err these days.

thanks,
-- 
js
suse labs