Re: [PATCH v5 1/6] regulator: lm363x: Make the gpio register enable flexible

From: Dan Murphy
Date: Wed Jun 05 2019 - 08:51:58 EST


On 6/5/19 7:02 AM, Dan Murphy wrote:

On 6/5/19 5:01 AM, Mark Brown wrote:
On Tue, Jun 04, 2019 at 12:43:40PM -0500, Dan Murphy wrote:
The use of and enablement of the GPIO can be used across devices.
Use the enable_reg in the regulator descriptor for the register to

Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>

v5 - No changes to the patch changes requested in this patch were done in
patch 4 of this series -
I was expecting this patch to just be completely dropped?  It looks like
the end result is very similar, we're still using enable_reg to get the
register and I don't see new validation added in patch 4.

I can squash patch 1 into 4.

Also not sure what you mean by new validation.

Disregard I understand.  The patch is missing the validation code.

Please comment on patch 4 to what you are looking for